Skip to content

fix: data-variant overwrites (in)valid border colors #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Apr 21, 2023
Merged

fix: data-variant overwrites (in)valid border colors #422

merged 22 commits into from
Apr 21, 2023

Conversation

mfranzke
Copy link
Member

Resolves #419

@mfranzke mfranzke added the bug Something isn't working label Apr 21, 2023
@mfranzke mfranzke added this to the Release 2.x milestone Apr 21, 2023
@mfranzke mfranzke self-assigned this Apr 21, 2023
@mfranzke mfranzke requested review from nmerget and dkolba as code owners April 21, 2023 06:08
@mfranzke mfranzke linked an issue Apr 21, 2023 that may be closed by this pull request
Form elements: data-variant overwrites (in)valid border colors #419
Closed
@mfranzke mfranzke requested a review from annsch as a code owner April 21, 2023 06:08
@mfranzke mfranzke changed the title chore: simplified this attribute fix: data-variant overwrites (in)valid border colors Apr 21, 2023
@github-actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ui.github.io/core/review/419-form-elements-data-variant-overwrites-invalid-border-colors

@mfranzke mfranzke enabled auto-merge (squash) April 21, 2023 06:24
nmerget
nmerget reviewed Apr 21, 2023
View reviewed changes
@mfranzke mfranzke requested a review from nmerget April 21, 2023 06:45
@mfranzke mfranzke marked this pull request as draft April 21, 2023 07:11
auto-merge was automatically disabled April 21, 2023 07:11

Pull request was converted to draft

@mfranzke
refactor: modern floating label for selects
2317074 
w/o necessary required on the select, yeah !
@mfranzke mfranzke marked this pull request as ready for review April 21, 2023 10:14
mfranzke added 3 commits April 21, 2023 12:20
@mfranzke
refactor: reunited the form validation SCSS placeholder
48a1acb 
we've found another way to support floating labels on selects w/o having them as a required element
@mfranzke
Revert "refactor: reunited the form validation SCSS placeholder"
3abdef3 
This reverts commit 48a1acb.
@mfranzke
style: further optimizations
0171c1b
@mfranzke mfranzke enabled auto-merge (squash) April 21, 2023 10:31
mfranzke
mfranzke commented Apr 21, 2023
View reviewed changes
@mfranzke mfranzke mentioned this pull request Apr 21, 2023
Open
@mfranzke mfranzke merged commit 0a4206a into main Apr 21, 2023
@mfranzke mfranzke deleted the 419-form-elements-data-variant-overwrites-invalid-border-colors branch April 21, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmerget nmerget nmerget approved these changes

@dkolba dkolba Awaiting requested review from dkolba dkolba is a code owner

@annsch annsch Awaiting requested review from annsch annsch is a code owner

Assignees

@mfranzke mfranzke

Labels
bug Something isn't working patterns
Projects
None yet
Milestone
Guidelines v2
Development

Successfully merging this pull request may close these issues.

Form elements: data-variant overwrites (in)valid border colors
2 participants
@mfranzke @nmerget