refactor: display icons by categories and as a poster #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfranzke
added
documentation
github-actions
bot
added
patterns
and removed
documentation
…ttps://github.com/db-ui/core into refactor-display-icons-by-categories-and-as-poster
|
This is actually the same as in db-ui-base, isn't it? Moreover, I don't like how we present the icons in this branch. I think we should use the tab-bar here as well and split the description, the current icon overview (because for me as a developer this is what I want to use), and the graphical overview we have in base. Maybe we need to talk about it |
auto-merge was automatically disabled
October 25, 2022 10:39
Pull request was converted to draft
|
Closing this in favour of db-ui/base#109 and as we will move all base stuff from DB UI Core into DB UI Base. |
mfranzke
deleted the
refactor-display-icons-by-categories-and-as-poster
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old way of displaying all of the icons was focusing on the names and HTML attributes and SCSS mixins mainly. But we'd like to move the focus to the visual part.
Backlog: