refactor: switched to a11y compliant HTML #417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔭🐙🐈 Test this branch here: https://db-ui.github.io/core/review/394-language-switcher-remove-listbox |
instead of the list items
….com/db-ui/core into 394-language-switcher-remove-listbox
This reverts commit c2e2081.
temporarily, until we render enterprise version of the styleguide as well
d-koppenhagen
approved these changes
Apr 19, 2023
d-koppenhagen
suggested changes
Apr 19, 2023
annsch
reviewed
Apr 19, 2023
d-koppenhagen
approved these changes
Apr 21, 2023
annsch
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #394
As a meaningful migration, you would need to do the following steps when using this component with hyperlinks included (we should mention this within the release notes):
role="listbox"from<ul class="cmp-language-switcher"HTML tagrole="option"from<liHTML tags and replacearia-selected="true"byaria-current="page"for the active language