Skip to content

Feat typo scale #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Nov 1, 2022
Merged

Feat typo scale #85

merged 15 commits into from
Nov 1, 2022

Conversation

nmerget
Copy link
Member

@nmerget nmerget commented Oct 12, 2022

  • Both font-size and line-height are currently being generated in pixel values, whereas we would need font-size to be a calculated rem value, and line-height should be a unitless value:

    The used value is this unitless multiplied by the element's own font size. The computed value is the same as the specified .

    I would have thought that this is just a configuration within style-dictionary, but the include only a transform to rem by default for scss and css transform groups: https://amzn.github.io/style-dictionary/#/transform_groups?id=scss

@github-actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ui.github.io/base/review/feat-typo-scale

@nmerget nmerget marked this pull request as ready for review October 13, 2022 09:00
@nmerget nmerget requested a review from mfranzke October 28, 2022 07:08
@annsch
Copy link
Collaborator

annsch commented Oct 28, 2022

when we use unitless values for line-height we have to make sure that they follow this principle:

Unitless values: use this number multiplied by the element's font size

The current values leads to the following:

Bildschirm­foto 2022-10-28 um 11 33 32

@nmerget
Copy link
Member Author

nmerget commented Oct 28, 2022

when we use unitless values for line-height we have to make sure that they follow this principle:

Unitless values: use this number multiplied by the element's font size

The current values leads to the following:

Bildschirm­foto 2022-10-28 um 11 33 32

I gonna change this, after the updates from zeplin

@nmerget nmerget enabled auto-merge (squash) November 1, 2022 11:32
@nmerget nmerget merged commit 65e6fb0 into dbux-3 Nov 1, 2022
@nmerget nmerget deleted the feat-typo-scale branch November 1, 2022 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants