-
Notifications
You must be signed in to change notification settings - Fork 3
Feat typo scale #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Feat typo scale #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔭🐙🐈 Test this branch here: https://db-ui.github.io/base/review/feat-typo-scale |
mfranzke
reviewed
Oct 24, 2022
mfranzke
reviewed
Oct 24, 2022
* feat: add spacing and sizing
� Conflicts: � package-lock.json
annsch
reviewed
Nov 1, 2022
annsch
reviewed
Nov 1, 2022
annsch
reviewed
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both font-size and line-height are currently being generated in pixel values, whereas we would need font-size to be a calculated
rem
value, and line-height should be a unitless value:I would have thought that this is just a configuration within style-dictionary, but the include only a transform to
rem
by default forscss
andcss
transform groups: https://amzn.github.io/style-dictionary/#/transform_groups?id=scss