Skip to content

fix: aligned tokens with Marketingportal definitions #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 1, 2023
Merged

fix: aligned tokens with Marketingportal definitions #328

merged 8 commits into from
Jun 1, 2023

Conversation

mfranzke
Copy link
Member

Resolves #326

@mfranzke mfranzke added the bug Something isn't working label May 23, 2023
@mfranzke mfranzke added this to the Release 1.0 milestone May 23, 2023
@mfranzke mfranzke self-assigned this May 23, 2023
@mfranzke mfranzke marked this pull request as ready for review May 23, 2023 06:50
@mfranzke mfranzke enabled auto-merge (squash) May 23, 2023 06:50
@github-actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ui.github.io/base/review/318-icons-fill-rule=evenodd-is-deleted-on-icon-fonts

@pschaub
Copy link
Contributor

pschaub commented May 25, 2023

@mfranzke the change of the keys (e.g. sm to s) would lead into a breaking change because this key is widely used in responsive TailwindCSS applications to define how something should behave across screen sizes. Would it be possible to stay with the common known sm, etc..?

@mfranzke mfranzke merged commit 2da604b into main Jun 1, 2023
@mfranzke mfranzke deleted the 318-icons-fill-rule=evenodd-is-deleted-on-icon-fonts branch June 1, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkolba dkolba dkolba approved these changes

@nmerget nmerget Awaiting requested review from nmerget nmerget is a code owner

@annsch annsch Awaiting requested review from annsch annsch is a code owner

Assignees

@mfranzke mfranzke

Labels
bug Something isn't working tokens
Projects
None yet
Milestone
Release 1.0
Development

Successfully merging this pull request may close these issues.

Tailwind Tokens: Breakpoints are inconsistent with guidelines
3 participants
@mfranzke @pschaub @dkolba