Skip to content

Add TypeScript Definitions #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 3, 2023
Merged

Add TypeScript Definitions #252

merged 3 commits into from
Jul 3, 2023

Conversation

shartte
Copy link
Contributor

@shartte shartte commented Feb 14, 2023

Additional notes:

  • Pre-commit hooks fail on Windows with issues related to Markdown, although this change includes no Markdown changes.
assets/icons/README.md:3:501 MD013/line-length Line length [Expected: 500; Actual: 533]
README.md:65:53 MD026/no-trailing-punctuation Trailing punctuation in heading [Punctuation: ' !!!']
ERROR: "lint:markdownlint" exited with 1.
  • The package.json currently lists build.js as it's entrypoint but that seems incorrect. It should probably be tokens.js to enable importing the tokens directly from @db-ui/base. (also: set module: true)

@mfranzke
Copy link
Member

@shartte thanks a lot for your contribution. I've added issues and PRs for the markdownlint problem in parallel.

@mfranzke mfranzke enabled auto-merge (squash) May 31, 2023 04:59
@mfranzke mfranzke merged commit 2a74f40 into db-ui:main Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants