feat: add filled base-icon properties #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔭🐙🐈 Test this branch here: https://db-ui.github.io/base/review/feat-base-icon-filled |
annsch
approved these changes
Nov 24, 2022
mfranzke
reviewed
Nov 24, 2022
Comment on lines
+14
to
+18
| @if $defaultFontProperties { | ||
| --icon-font-family: "#{"icons-" + $size + "-" + $style}", | ||
| "missing-icons"; | ||
| --icon-font-size: #{to-rem($pxValue: $size)}; | ||
| } |
There was a problem hiding this comment.
I like the idea making this optional, but in that case we could as well define it as a fallback to the CSS Variables reference on the following code lines, which would be a little simpler and prevents unexpected results (like e.g. not necessarily documenting that new parameter):
https://github.com/db-ui/base/blob/cf16a3bd1e2078e5bf8209dbcc44884bc112c5b2/scss/icon/_icons.helpers.scss#L38L40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.