Skip to content

refactor: renamed bundle scss file and fixed path in usage files #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 1, 2022

Conversation

annsch
Copy link
Collaborator

@annsch annsch commented Nov 1, 2022

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2022

🔭🐙🐈 Test this branch here: https://db-ui.github.io/base/review/refactor-bundle

@annsch annsch merged commit acc7fa7 into dbux-3 Nov 1, 2022
@annsch annsch deleted the refactor-bundle branch November 1, 2022 14:11
@@ -15,9 +15,9 @@
"copy:assets": "cpr assets build/assets -d",
"copy:scss": "cpr scss build/scss -o",
"build:style-dictionary": "node style-dictionary.js && npm run copy:scss",
"build:patternlab-css": "sass source/css/db-ui-base.scss:out/css/db-ui-base.css --style=compressed --embed-sources --load-path=node_modules",
"build:patternlab-css": "sass source/css/patternlab.scss:out/css/patternlab.css --style=compressed --embed-sources --load-path=node_modules",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@annsch why not call it documentation.scss or something similar instead?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mfranzke this branch was merged without duscussing your feedback, sry. I'll open an issue for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants