Skip to content

Comments

Remove moment.#523

Merged
wzrdtales merged 1 commit intodb-migrate:masterfrom
wtgtybhertgeghgtwtg:remove-moment
Dec 3, 2017
Merged

Remove moment.#523
wzrdtales merged 1 commit intodb-migrate:masterfrom
wtgtybhertgeghgtwtg:remove-moment

Conversation

@wtgtybhertgeghgtwtg
Copy link
Contributor

It doesn't seem to be used or be a peerDependency and the current version has a security vulnerability.

@ghost
Copy link

ghost commented Nov 29, 2017

There were the following issues with this Pull Request

  • Commit: 39962ce
    • ✖ message may not be empty
    • ✖ type may not be empty

@wzrdtales
Copy link
Member

Thanks for your contribution!

Can you please check back, that all checks pass?

@ghost
Copy link

ghost commented Nov 30, 2017

There were the following issues with this Pull Request

  • Commit: 7a0e487
    • ✖ message may not be empty
    • ✖ type may not be empty

@wtgtybhertgeghgtwtg
Copy link
Contributor Author

No clue how to fix the commitlint error. Looks like all commits since you implemented it have just been straight pushes to master, so there aren't any examples for me to go off of, either. You can take it as is or close it and do it yourself; it's just a one-line fix.

@wzrdtales
Copy link
Member

Signed-off-by: wtgtybhertgeghgtwtg <wtgtybhertgeghgtwtg@gmail.com>
@z0al
Copy link

z0al commented Dec 3, 2017

Hey @wtgtybhertgeghgtwtg, sorry about that, currently the bot supports Conventional Commits specification. I should point to it in the bot comments. I will try to fix this soon.

If you have a better idea or found a bug kindly report an issue here, and I will try to help!

Thank you

@wzrdtales
Copy link
Member

@wtgtybhertgeghgtwtg Thanks for surviving the fuss :) And thanks again for contributing!

@ahmed-taj Yes a more detailed output of what is actually wrong would help users.

@wzrdtales wzrdtales merged commit ae6cd4b into db-migrate:master Dec 3, 2017
@wtgtybhertgeghgtwtg wtgtybhertgeghgtwtg deleted the remove-moment branch December 3, 2017 20:01
@dijonkitchen
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants