Skip to content

Comments

Create migrations table in specified schema#287

Merged
wzrdtales merged 1 commit intodb-migrate:v0.9.xfrom
mike-zorn:use-schema-migrations-table
Aug 7, 2015
Merged

Create migrations table in specified schema#287
wzrdtales merged 1 commit intodb-migrate:v0.9.xfrom
mike-zorn:use-schema-migrations-table

Conversation

@mike-zorn
Copy link

In postgres, if you create a migrations table in one schema of your database,
and then try to use this for migrations in another schema, it will not create
the migrations table in the second schema which will prevent any migrations
from running on that schema. This creates the migrations table in that second
schema when the schema parameter is specified.

In postgres, if you create a migrations table in one schema of your database,
and then try to use this for migrations in another schema, it will not create
the migrations table in the second schema which will prevent any migrations
from running on that schema. This creates the migrations table in that second
schema when the schema parameter is specified.
@mike-zorn
Copy link
Author

NB the build only failed on iojs-3 and it failed there because it failed to build the native modules this module depends upon.

@wzrdtales
Copy link
Member

Yeah I know about io.js - 3. I'm going to remove it from the builds until it gets fixed, haven't pushed my changes of yesterday already....

See also this note concerning this:
#286

@wzrdtales wzrdtales added the bug label Aug 7, 2015
@wzrdtales wzrdtales self-assigned this Aug 7, 2015
@wzrdtales wzrdtales added this to the v0.10.0 milestone Aug 7, 2015
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't use async, I'm currently working on kicking this dependency out of the project. The whole project will rely on promises in the future.

I have ported your changes to use bluebird in the master repo, but please consider this for future contributions.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

wzrdtales pushed a commit that referenced this pull request Aug 7, 2015
wzrdtales added a commit that referenced this pull request Aug 7, 2015
[Bugfix] Create migrations table in specified schema
@wzrdtales wzrdtales merged commit 75f79ca into db-migrate:v0.9.x Aug 7, 2015
@mike-zorn mike-zorn deleted the use-schema-migrations-table branch August 7, 2015 16:15
@wzrdtales
Copy link
Member

Considered as bugfix, releasing as patch 0.9.19

@mike-zorn
Copy link
Author

Awesome! Thanks so much!

@wzrdtales
Copy link
Member

Just waiting for the CI first, oh ok, its done already..., faster as usual.

Published!

@mike-zorn
Copy link
Author

💥 Thanks, again!

@wzrdtales
Copy link
Member

No problem, thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants