db:create always returns with exit code 1

[pc-jedi]

I'm submitting a...

• Bug report
• Feature request
• Question

Current behavior

db-migrate db:create asdf return with exit code 1

Expected behavior

db-migrate db:create asdf return with exit code 0

What is the motivation / use case for changing the behavior?

Exit code else then 0 stands for an error. Therefore some tools fail if the called command exits with error (return code not 0).

Environment

db-migrate version: 0.10.5

Additional information:
- Node version: v9.7.1
- Platform: Linux

[ollyjshaw]

👍 I'm looking at using db-migrate in a build pipeline.

[oroce]

I'm having the same issue, it seems the exit code 1 is hardcoded: https://github.com/db-migrate/node-db-migrate/blob/master/lib/commands/db.js#L35

I guess it should be: else process.exit(err ? 1 : 0);

[wzrdtales]

Thanks for reporting, yes this is an unwanted bug.

[northern]

I experience this same behaviour when I run db-migrate with a yarn/npm run command. E.g, in package.json:

  "scripts": {
    "migrate": "db-migrate"
  }

And running either npm run migrate or yarn migrate will always trigger exit code 1.

[naxxster]

I think there is same bug in the db:drop command.

[ClaytonNorthey92]

@wzrdtales is there any progress made on this issue? if not, I may be able to help. Looking to use this functionality in an npm script and it functions correctly besides the exit status.

[wzrdtales]

No not yet, a lot of things are happening in the background (founding my own company and a lot of different stuff). I plan to invest more time into db-migrate in the near future and currently also search some sponsors, to create actually room for this.

I do welcome any help though. Feel free to give it a shot and reach out if you should have any questions!

[wzrdtales]

Edit: actually 486cb78 there have been some changes, need to validate, that this problem was fixed. This was some while ago though.

[pc-jedi]

I updated to 0.11.2 to validate that the issue still persists.
Sadly the issue has not been fixed yet.

[wzrdtales]

Ok thanks for verifying. Have a few minutes right now :) will push out a fix