Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Atom Syntax to Atom 1.0 API #197

Merged
merged 7 commits into from
Apr 16, 2016
Merged

Conversation

arminrosu
Copy link
Contributor

Ahoy!

TLDR; Turn this:

screen shot 2016-04-04 at 15 47 20

to this:

screen shot 2016-04-04 at 15 48 23

Notice how the UI changes with the theme.

@daylerees could you please have a look at these:

  • build/resources/patterns/atom/syntax-variables.pattern contains more variables that can be set in Atom. I don't know which corresponds to your own variables. From what I can tell now, the atom syntax looks great anyway, but this would add some polish.
  • how do you build the project? I ran cd ./build; composer install; php run.php raincolour;.

I will commit the compiled files too if you think the PR is good.

Thanks for making pretty colors for me to look at :)

@daylerees
Copy link
Owner

Thanks for this @arminrosu , gonna take a proper look this weekend! You're right about the build process, and don't worry about excess values. You just have to match up the theme as best as possible. Don't need to use every value. :)

@daylerees
Copy link
Owner

Thanks!

@daylerees daylerees merged commit 734e7aa into daylerees:master Apr 16, 2016
@jonboiser
Copy link

I will commit the compiled files too if you think the PR is good.

Does the ./atom folder need to be rebuilt? Last update to that folder is still reading "2 years ago".

@arminrosu
Copy link
Contributor Author

Yes it does. I emailed Dayle about it a few days ago, waiting for a response.

cusxio added a commit to cusxio/atom-colour-schemes that referenced this pull request Nov 6, 2016
@cusxio
Copy link

cusxio commented Nov 6, 2016

I made a temporary repository that holds the rebuilt colour schemes for Atom so that other users don't have to rebuild them.

@arminrosu
Copy link
Contributor Author

@cusxio thanks, great idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants