Skip to content

Conversation

@yondonfu
Copy link
Contributor

@yondonfu yondonfu commented Nov 7, 2025

  • Renamed KV Attention Bias -> Cache Bias to more closely align with the naming of the other cache related params (the user of the term "cache")
  • Fixed overflow issue for the pill value for Cache Bias - I could not see the value when it has a decimal places eg 0.1 on a small screen because of overflow
  • Updated the tooltip description of Cache Bias
  • Moved Cache Bias in the Settings panel so it is grouped with the other cache related params

Signed-off-by: Yondon Fu <yondon.fu@gmail.com>
Copy link
Collaborator

@ryanontheinside ryanontheinside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Needed if compiling self-attn block

Signed-off-by: Yondon Fu <yondon.fu@gmail.com>
@ryanontheinside ryanontheinside merged commit ce204c3 into ryanontheinside/experiments/attn-bias Nov 7, 2025
1 check passed
@yondonfu yondonfu deleted the yf/attn-bias-changes branch November 7, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants