Skip to content

Conversation

@fanaugen
Copy link

Before this change it was not possible to override the SQLTAP_SCHEMA
with a custom value for trying things out in development, because this
script would download the schema from the dist server and overwrite it,
or exit with an error on line 17 if SCHEMA_URL was set to an empty
string.

Before this change it was not possible to override the `SQLTAP_SCHEMA`
with a custom value for trying things out in development, because this
script would download the schema from the dist server and overwrite it,
or exit with an error on line 17 if SCHEMA_URL was set to an empty
string.
@fanaugen
Copy link
Author

I need this so I can run sqltap in docker-compose locally by mounting a directory where my schema.xml sits (with local modifications) and overriding the default with this:

version: '2'
services:
  fetch:
    image: local_fetch
    ports:
      - 3307:3000
    volumes:
      - ~/dev/config/common:/config
    environment:
      - SQLTAP_SCHEMA=/config/schema.xml
      - SCHEMA_URL=local

local is just a placeholder, it could as well be any other string that does not start with http

@fanaugen fanaugen requested a review from eliten00b March 14, 2018 16:47
@eliten00b
Copy link
Member

eliten00b commented Mar 14, 2018

Why not http://local ? I mean, what would curl download from local ? And if you dont want to download a remote schema, you dont need.

@eliten00b eliten00b merged commit 7a20932 into master Mar 15, 2018
@eliten00b eliten00b deleted the allow_local_schema branch March 15, 2018 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants