Fix coercion for embedded shallow attributes type, receiving unexpected parameters#34
Open
javierseixas wants to merge 6 commits into
Conversation
javierseixas
commented
Nov 15, 2019
| # @private | ||
| # | ||
| # @since 0.9.4 | ||
| class Boolean; end |
Author
There was a problem hiding this comment.
Needs to define Boolean class for adding to the DEFAULT_TYPE_OBJECTS.
Options in attributes
javierseixas
force-pushed
the
fix-nested-shallow-attributes-with-unexpected-parameters
branch
from
August 14, 2020 02:48
c4c8b43 to
80990d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PROBLEM
Having two classes related like follow:
... when the embedded class receives parameters that doesn't match the defined attributes:
... an error raises because doesn't find the definition in the class.
When a class including
ShallowAttribuesis initialized, during the initialization parameters non matching attributes are dismissed. But it doesn't happen during the lower levels in the hierarchy, because the objects are creating according to the type.SOLUTION
Adding some logic during the
typecoercion and initialization avoid the conflict.