Fix coercion for array type: do not coerce array value if type is the same as specified

[evheny0]

Hi!

I've noticed some inconsistency in array type coercion. Right now if you specify attribute type

attribute :some_attribute, Array, of: SomeClass

it will coerce array values no matter of their class, even if they are the same class as specified in of param. This is a bit different from other types, which will not coerce if class is the same as declared in type.

Here is an example of current behavior:

class Person
  include ShallowAttributes

  attribute :addresses_array, Array, of: Hash
  attribute :address_hash, Hash
end

Person.new(address_hash: { street: "abc" })
# <Person address_hash={:street=>"abc"} addresses_array=[]>

Person.new(addresses_array: [{ street: "abc" }])
# NoMethodError: undefined method `coerce' for {}:Hash

And after fix behavior:

class Person
  include ShallowAttributes

  attribute :addresses_array, Array, of: Hash
  attribute :address_hash, Hash
end

Person.new(address_hash: { street: "abc" })
# <Person address_hash={:street=>"abc"} addresses_array=[]>

Person.new(addresses_array: [{ street: "abc" }])
# #<Person addresses_array=[{:street=>"abc"}]>

I hope this way there will be less confusion 😄

[coveralls]

Coverage increased (+0.0002%) to 99.778% when pulling f299bd0 on evheny0:fix-array-subtypes-coercion into 51f5c1b on davydovanton:master.

[davydovanton]

The fix looks good for me. Could you please fix CI? I'll merge this PR after this. Thanks! 👏

[lmmendes]

Hi @davydovanton when can we expect this bug fix to get merged and a release pushed to rubygems?

[evheny0]

Hi @davydovanton! CI is successful except for the jruby head, which fails on master as well. I believe the branch is ready to be merged :)

[evheny0]

Sorry for the delay 😄

[javierseixas]

Hi! Waiting for this fix to be released! ☝️