Skip to content

More consistent command output from 'dinictl enable' and 'dinitctl disable' #507

Description

@davmac314

The dinitctl enable command will currently wait for the named service to start and issue a 'started' message, but only if the service hasn't already started (in which case it outputs nothing).

The dinitctl disable command on the other hand doesn't wait for the service to stop. This is inconsistent. (It does print a warning if the service won't stop, i.e. target state is not 'stopped').

In both cases there is a minor race, internally: after the enable/disable is issued, a separate status command is issued to determine target state. However the state may have changed between the two commands.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Pending releaseFixed on main or another branch, but fix not yet included in a release.

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions