Fix onSelection bug

[ekilah]

Fixes #142

Props in react can change over time, so they should not be saved when a component first mounts and then never updated. This causes issues when you, say, have a dynamic callback in onSelection that changes over time. Without this change, this library was calling the old/outdated callback instead of the most recent one.

This is a quick and easy fix, though I imagine a better fix would involve rewriting more of the code here. I don't see any reason for this to be problematic though. I've used this in my own project where I observed the bug and this does resolve it.

This PR includes /dist which is built via npm run prePublishOnly && git add -f ./dist/, which we wouldn't include before merging this PR. But in order to use this fork/branch directly in package.json I believe this was necessary for now.

For anyone else wanting to use this fork to fix #142 before it is merged, you can use this line in your package.json:

"react-aria-menubutton": "https://github.com/MercuryTechnologies/react-aria-menubutton.git#fixOnSelectionBug",

[shirshendubhowmick]

@ekilah Thanks for the PR.

The pr looks good.

However we do not want to make the dist the part of the codebase, since we are very active on releasing a new version on npm as soon as something significant gets merged.

Please remove the entire dist from the PR and will be happy to merge & release a new version.

[ekilah]

@shirshendubhowmick yeah, like I mentioned in the PR desc I only did that so I could use the fork for myself until the PR was ready to merge 👍

I've removed it now, when you get a chance to review. Thanks!