Add: number recognition, date recognition, field-names from first row, field names from supplied parameter #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think the underlying implementation could be improved; it eats stack. I'm going to see if I can fix that.
simon-brooke
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this includes:
I've also upped the default Clojure version to 1.8, which may not suit you.
I'm seeing errors in one of your unit tests, perhaps because of the change to 1.8; and your benchmarks do not work for me, possibly for the same reason. I have not investigated either deeply.
I believe that the core algorithm of
parse-csv-with-optionscould be written, probably usingreduce, to consume less stack, and I may have a go at that when I have time.I hope this is useful to you.