Implement SecureStore class #20

davidsaada · 2018-11-06T14:11:58Z

Implement SecureStore class.
@dannybenor @yossi2le @offirko @theamirocohen Please review.

Make minor copy edits for active voice, branding and deletion of extra spaces.

Currently the following commands in examples.py, do_import() do_deploy() do_versionning() do_clone() all return a success status (ie 0) irrespective of any errors originating from their sub-functions. This PR fixes this. Now these commands will return one of: 0 - success 1 - general failure x - failure returned by a subprocess.call function

subprocess.call() does not by default return a status value. Update the commands to add shell=True which forces a return value. Also convert the commands to a single string rather than a list as this plays more nicely with both linux and windows. Also fix a spurious :

Transport is a member of TLSSocket which is derived from TLSSocketWrapper. Make sure that TLSSocketWrapper::close() is called before the transport is destroyed.

TCP and UDP sockets are automatically available when mbed.h is included in an application. This change lets the TLSSocket be used in the same way.

Remove _thread suffix and rename threads.

Simplify the document. More information is provided on our documentation portal, link it here

Fix off-by-one-error in BusIn/Out

Remove unnecessary commas, and standardize heading capitalization.

Remove unnecessary comma.

Increase EMAC test timeout to 1400 seconds

Add get_erase_value() support

Add names to system thread

Rollup PR for docs

…lehto/mbed-os into rollup

… rollup

…/mbed-os into rollup

…ed-os into rollup

Rollup PR: Docs + small fixes

dannybenor

I reviewed securestore cpp and h
Fantastic Job!

dannybenor · 2018-11-07T09:48:21Z

features/storage/kvstore/securestore/SecureStore.cpp

+            goto fail;
+        }
+        auth_started = true;
+        // Although key is not part of the data, we calculate CMAC on it as well


// Although name is not part of the data, we calculate CMAC on it as well

dannybenor · 2018-11-07T09:58:16Z

features/storage/kvstore/securestore/SecureStore.cpp

+static const uint32_t enc_block_size    = 16;
+static const uint32_t cmac_size         = 16;
+static const uint32_t iv_size           = 8;
+static const uint32_t scratch_buf_size  = 32;


you can use a bigger buffer, maybe 256 bytes

Good idea. Will check whether this has any effect on performance.

dannybenor · 2018-11-07T10:13:03Z

features/storage/kvstore/securestore/SecureStore.cpp

+        }
+        auth_started = true;
+
+        // Although key is not part of the data, we calculate CMAC on it as well


dannybenor · 2018-11-07T10:20:50Z

features/storage/kvstore/securestore/mbed_lib.json

+    "macros": ["MBEDTLS_CIPHER_MODE_CTR", "MBEDTLS_CMAC_C"],
+    "config": {
+    }
+}


Something strange at the end of this file

All I need here is to have the cipher and CMAC defines set. Nothing needed in the config.

dannybenor · 2018-11-07T10:42:38Z

There is a strange character at the end of the file...

davidsaada · 2018-11-07T12:57:43Z

Fixed all issues. Enlarging the scratch buffer indeed helped with the performance, but that's just because there were less calls to TDBStore. Seems like TDBStore is the problem.

mbed-cloud-client 2.0.1.1

ARMC5 failed to compile the code with debug-profile (!!) as va_list is getting into std:: namespace when one includes <cstdarg>. Other compilers seem to be more relaxed, and so is ARMC5 if compiled with other profiles. Add the explicit std:: to references of va_list. While here, remove one extra copy of "#include "PlatformMutex.h"" and a "#include <stdarg.h>" which is kind of duplicate of "#include <cstdarg>". Error being fixed: --8<--8<--8<-- Compile [ 81.8%]: ATHandler.cpp [Error] ATHandler.h@552,0: #20: identifier "va_list" is undefined [Error] ATHandler.cpp@1226,0: ARMmbed#147: declaration is incompatible with "void mbed::ATHandler::handle_args(const char *, <error-type>)" (declared at line 552 of "./mbed-os/features/cellular/framework/AT/ATHandler.h") [ERROR] "./mbed-os/features/cellular/framework/AT/ATHandler.h", line 552: Error: #20: identifier "va_list" is undefined "./mbed-os/features/cellular/framework/AT/ATHandler.cpp", line 1226: Error: ARMmbed#147: declaration is incompatible with "void mbed::ATHandler::handle_args(const char *, <error-type>)" (declared at line 552 of "./mbed-os/features/cellular/framework/AT/ATHandler.h") ./mbed-os/features/cellular/framework/AT/ATHandler.cpp: 0 warnings, 2 errors

SenRamakri and others added 30 commits October 29, 2018 13:47

Kernel.h doxygen update

ad88218

Updated attach_thread_terminate_hook doxygen comments

4cdcdc1

Edit Kernel.h

2418d9c

Make minor copy edits for active voice, branding and deletion of extra spaces.

exclude vendor's EMAC driver from doxy

b01c857

fixed NetworkInterface Class missing in doxy

60cc0c2

Increase EMAC test timeout to 1400 seconds

e3623b9

Fix off-by-one-error in BusIn/Out

74f7259

Add generic BlockDevice test for contiguous erase/write/read.

ebef79a

Add generic BlockDevice test for get_erase_value().

c3e0e3e

Added mutex to DataFlash for thread safety

7614055

Added missing mutex to DataFlash for thread safety.

0d04f03

feat: Name cellular FSM queue thread

56a12ce

feat: Name PPP thread

1f4f623

Make sure that close() is called before the transport is destroyed.

f92108c

Transport is a member of TLSSocket which is derived from TLSSocketWrapper. Make sure that TLSSocketWrapper::close() is called before the transport is destroyed.

Typo fixes in Doxygen for Platform

766359c

Add missing include for TLSSocket

07eb6bd

TCP and UDP sockets are automatically available when mbed.h is included in an application. This change lets the TLSSocket be used in the same way.

Fix typos in Events doxygen

ae673d6

Fix typos in RTOS doxygen.

3008de5

fix: Update thread names

3f635ef

Remove _thread suffix and rename threads.

feat: Add name to shared queue threads

467a7b6

fix: Change cellular FSM thread name

440905a

fix: Remove rtx from main thread name

2ef82e1

Fix compile warning about initializing and variable order

c7afb91

Add get_erase_value() support

2df7258

readme: add license section

09ee5f9

readme: add note about 3rd party code licenses

8ec69e6

contributing: update the text

f8fc0b3

Simplify the document. More information is provided on our documentation portal, link it here

Readme: add license guide doc page

97cb833

davidsaada force-pushed the david_securestore branch from 5d4a1bf to 705c29e Compare November 6, 2018 17:35

Cruz Monrreal and others added 15 commits November 6, 2018 13:43

Merge pull request ARMmbed#8606 from pea-pod/fix-bus-oboe

5549c52

Fix off-by-one-error in BusIn/Out

Edits in README.md

64ef110

Remove unnecessary commas, and standardize heading capitalization.

Remove comma in CONTRIBUTING.md

819f002

Remove unnecessary comma.

Remove comma in CONTRIBUTING.md

44aaad4

Remove unnecessary comma.

Merge pull request ARMmbed#8604 from SeppoTakalo/emac_timeout

9072b55

Increase EMAC test timeout to 1400 seconds

Merge pull request ARMmbed#8639 from offirko/offir-mbed-qspif3

6042ea3

Add get_erase_value() support

Merge pull request ARMmbed#8612 from vidavidorra/master

0c2d35f

Add names to system thread

Merge pull request ARMmbed#8652 from 0xc0170/dev_rollup

c792d33

Rollup PR for docs

Merge branch 'fix_possible_memory_leak' of ssh://github.com/KariHaapa…

ddd82a9

…lehto/mbed-os into rollup

Merge branch 'fix_licensing' of ssh://github.com/0xc0170/mbed-os into…

f7eb135

… rollup

Merge branch 'fix_compile_warning' of ssh://github.com/KariHaapalehto…

7536876

…/mbed-os into rollup

Merge branch 'sdblockdevice_deselect' of ssh://github.com/jarlamsa/mb…

fd744e7

…ed-os into rollup

Merge branch 'PR_M33' of ssh://github.com/jeromecoutant/mbed into rollup

edb6d9d

Merge branch 'sen_KernelDoxyUpdate' of ssh://github.com/SenRamakri/mb…

0a8f5e0

…ed-os into rollup

Merge pull request ARMmbed#8663 from cmonr/rollup

96191e2

Rollup PR: Docs + small fixes

dannybenor requested changes Nov 7, 2018

View reviewed changes

davidsaada force-pushed the david_securestore branch from 705c29e to a54c939 Compare November 7, 2018 13:08

David Saada added 5 commits November 7, 2018 15:30

Support erase value in Flash HAL drivers, FlashIAP and block devices

4bf4ac1

Add a Unity macro to assert on platform error code difference

9f2bbbc

KVStore & derived classes: design docs & implementation

d616a5b

Implement TDBStore class

5a4f1d1

Implement SecureStore class

4b6a2fe

davidsaada force-pushed the david_securestore branch from a54c939 to 4b6a2fe Compare November 7, 2018 13:42

davidsaada closed this Nov 7, 2018

davidsaada deleted the david_securestore branch December 6, 2018 13:05

davidsaada pushed a commit that referenced this pull request Dec 31, 2018

Merge pull request #20 from ARMmbed/release-2.0.1.1

62de4b8

mbed-cloud-client 2.0.1.1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Implement SecureStore class #20

Implement SecureStore class #20

Uh oh!

davidsaada commented Nov 6, 2018

Uh oh!

dannybenor left a comment

Uh oh!

dannybenor Nov 7, 2018

Uh oh!

dannybenor Nov 7, 2018

Uh oh!

davidsaada Nov 7, 2018

Uh oh!

dannybenor Nov 7, 2018

Uh oh!

dannybenor Nov 7, 2018

Uh oh!

davidsaada Nov 7, 2018 •

edited

Loading

Uh oh!

dannybenor commented Nov 7, 2018

Uh oh!

davidsaada commented Nov 7, 2018

Uh oh!

Uh oh!

Implement SecureStore class #20

Implement SecureStore class #20

Uh oh!

Conversation

davidsaada commented Nov 6, 2018

Uh oh!

dannybenor left a comment

Choose a reason for hiding this comment

Uh oh!

dannybenor Nov 7, 2018

Choose a reason for hiding this comment

Uh oh!

dannybenor Nov 7, 2018

Choose a reason for hiding this comment

Uh oh!

davidsaada Nov 7, 2018

Choose a reason for hiding this comment

Uh oh!

dannybenor Nov 7, 2018

Choose a reason for hiding this comment

Uh oh!

dannybenor Nov 7, 2018

Choose a reason for hiding this comment

Uh oh!

davidsaada Nov 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dannybenor commented Nov 7, 2018

Uh oh!

davidsaada commented Nov 7, 2018

Uh oh!

Uh oh!

davidsaada Nov 7, 2018 •

edited

Loading