Draft
Conversation
DECDRLBR, DECERLBRP, and DECERLBRA are all implemented and seem to be working. The device attribute extension is reported. Behaviour matches "Interaction of Ruled Lines and Other DECterm Escape Sequences" except for ED, DECDWL and DECDHL. At a minimum the following still needs to be done: * Form Feed (Ctrl+L) and ED-2 should preserve ruled lines on the screen * DECDWL and DECDHL should not affect ruled lines (they shouldn't be stretched like they are now) * Control sequences documentation
DECterm ruled lines are not supposed to be affected by double-height/double-wide lines, so draw them after dealing with those so they don't get stretched along with the text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the result of a quick investigation to see how easy or hard it is to implement this. I've not decided if its actually worth having yet, so this PR is just to keep track of the work done so far in case I decide to finish it of later
So far the code here implements DECDRLBR, DECERLBRP, and DECERLBRA which seem to be working ok:

I've checked the behaviour against the Interaction of Ruled Lines and Other DECterm Escape Sequences table in the documentation - only DECDWL, DECDHL and ED-2 (erase screen) are not behaving correctly at the moment.
The implementation at this stage:
COMMON_LVB_GRID_*) so it might be possible to support it in the console version but probably not worthwhile. This restriction means it doesn't impact memory use of the OS/2 version, or the Windows console version.If ruled lines are to be supported, then at a minimum the following still needs to be done to finish it off:
clrscreen- possibly a snapshot of the lines will need to be taken first, then restored afterwards, as trying to copy the attributes from scrollback won't work if scrollback is disabled.There are also some more questions that need to be answered by further testing against DECterm:
printf '\x1b[15;;;;,t'do anything?printf '\x1b[15;;;;,s'do anything?