Open
Conversation
|
Sorry, this doesn't work. Causes unpredictable pausing during playback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi I'm working on a React Native 0.59 project using
react-native-youtube v1.1.0and wanted to backport a couple of commits from newer versions. Specifically...I branched from commit 1c2d9d (that seemed to be the last of the v1 commits) and made the changes. Seems to be working very well! 🍾 🍸
I gave mine a new version in the package.json (v1.1.1), sitting on branch v1.1.1 of my fork. Hoping it's simple to merge into a new branch in your repo, and that someone might find it as useful as we have.
Many thanks for your great work!
Chichi