Typescript type fixes + example code in .tsx#444
Open
tasinet wants to merge 9 commits intodavidohayon669:masterfrom
Open
Typescript type fixes + example code in .tsx#444tasinet wants to merge 9 commits intodavidohayon669:masterfrom
tasinet wants to merge 9 commits intodavidohayon669:masterfrom
Conversation
Props: added apiKey: string
on{State,Quality,...}: added handler definitions
StandaloneAndroid: fixed playlistId
|
@davidohayon669 could you please review and merge this PR? In TS project I have an annoying error in any way, whether there is apiKey or not, because propTypes require it when the TS types haven't it. Also there is an already issue #452, we (users) really need it. Thank you. |
Author
|
@davidohayon669 Any thoughts or feedback on this? Looking forward to some kind of progress, if at possible. Feel free to reach out privately as well. Thanks! |
|
Any updates on this PR? Getting these type fixes in would really make my dev experience with this library much better. @tasinet thanks for opening this by the way! And @davidohayon669 thanks for the library, been really nice to work with 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few small typescript bugfixes & improvements: (which got this ball rolling)
YouTubeStateand on[Stuff] callbacks properly typedA bigger one: A typescript version of the example.
I have named this
ReactNativeYouTubeExample.typescript.tsxso that there is no confusion as to which one is in play, along with instructions at the top to rename before use. I took a few liberties but nothing major. Let me know if you want any changes.Utility stuff:
I'm not sure if this one could be leaner or if it makes much difference.
Tests
TODO