Change type of variables related to time to float#281
Open
ghsdh3409 wants to merge 7 commits intodavidohayon669:masterfrom
Open
Change type of variables related to time to float#281ghsdh3409 wants to merge 7 commits intodavidohayon669:masterfrom
ghsdh3409 wants to merge 7 commits intodavidohayon669:masterfrom
Conversation
Return float current time in the currentTime()
Change time variable type to float
Fix time calculation
Author
ohtangza
approved these changes
Mar 31, 2018
ohtangza
left a comment
ohtangza
left a comment
There was a problem hiding this comment.
This pull request changes the type of seconds from integer to float by changing its data type. This only changes the type, not the value, so complies with backward-compatibility.
|
@ohtangza @ghsdh3409 hey guys, any chance we could get this merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
seekToandcurrentTimeworked with integer second.seekToandcurrentTime.seekToandcurrentTimeworks on both iOS and Android.Test/Review Plan
Comment