Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SECURITY] use Files.createTempFile instead of File.createTempFile #95

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

davidmoten
Copy link
Owner

File.createTempFile creates a file that is world readable. This PR fixes that security vulnerability.

@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2022

Codecov Report

Base: 88.11% // Head: 88.11% // No change to project coverage 👍

Coverage data is based on head (c1f0d6d) compared to base (6d342ce).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #95   +/-   ##
=========================================
  Coverage     88.11%   88.11%           
+ Complexity      463      462    -1     
=========================================
  Files            67       67           
  Lines          3736     3736           
  Branches        490      490           
=========================================
  Hits           3292     3292           
  Misses          287      287           
  Partials        157      157           
Impacted Files Coverage Δ
...om/github/davidmoten/rx2/buffertofile/Options.java 83.63% <100.00%> (ø)
...rx2/internal/flowable/buffertofile/PagedQueue.java 89.81% <0.00%> (-1.86%) ⬇️
...oten/rx2/internal/flowable/FlowableMaxRequest.java 90.00% <0.00%> (+2.50%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@davidmoten davidmoten merged commit 9db45fd into master Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants