Avoid requesting the default schedulers if a scheduler is specified explicitly. #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zubchenok
changed the title
|
@davidmoten would you consider pull it? |
|
Hi @zubchenok, yes I'll review it now, thanks for contributing! |
|
I'll review state of dependencies and plugins and release shortly |
|
Released to Maven Central in version 0.2.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if I specify a scheduler for
RetryWhen, a default scheduler fromSchedulersclass is still requested by callingSchedulers.computation()method.It is needed to avoid requesting of a default scheduler from
Schedulerswhen another scheduler is specified inRetryWhencause it callsRxJavaPlugins.onComputationHandleron every request while the requested default scheduler is not actually used.Same for
buffertofile.Options, butSchedulers.io()is used there.