Support for object crate not returning null symbol/section #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current git version of `object` no longer returns the null symbol or section at index 0. For sections, check for this and add an extra section slot if needed. For symbols, there are multiple places where we iterate over the input symbols, and adding an extra symbol every time is a bit ugly. Instead, add `SymbolIdRange` to recording the starting index and add methods to convert between id, vec index, and ELF index. These methods also include debug assertions to validate the values are in the correct range.
|
I was trying to get back to finishing off #5, but I discovered that gimli-rs/object#679 has broken wild. Not sure how you feel about the changes in this PR. Other options would be to switch wild to using |
|
Thanks for the fix! I think the BTW, if it makes it easier at any point, I'm happy to temporarily switch to using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current git version of
objectno longer returns the null symbol or section at index 0.For sections, check for this and add an extra section slot if needed.
For symbols, there are multiple places where we iterate over the input symbols, and adding an extra symbol every time is a bit ugly. Instead, add
SymbolIdRangeto recording the starting index and add methods to convert between id, vec index, and ELF index. These methods also include debug assertions to validate the values are in the correct range.