Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey David
I've made some changes to the PR, mainly to fix some nasty inconsistent crashes I experienced, seemingly because you keep reference of keyframe and layer but at some point those references are not accessible in memory anymore. In general I didn't see the need to add that complexity for now and therefore removed those variables, we can optimise later if neccesary.
I've changed the text edit widget to a variation of QPlainTextEdit, mainly to get multiple lines but also by creating my own class derived from QPlainTextEdit, we can now update the fields based on its focus event. This means that the apply button becomes redundant because it will update whenever you leave the widget, eg. click no the canvas, change tool etc...
A few things to note:
Unless you initialise a class object in the header eg. Keyframe keyframe and not KeyFrame* keyframe, you should use forward declaration and declare the include in the source file instead, this can make a big difference in compile time as the header has to recompile every time but the class can be cached.
Avoid stuff like this:
it's hacky, instead create a tag and use that attribute, like you did previously.
Thanks for taking the initiative to make this, I hope you find my comments helpful :)