Flush debounced changes when form is unmounted

[FelixHenninger]

Hi everybody, hi @davidkpiano,

thanks for creating this awesome library! It is truly super-helpful, and I very much enjoy using it. This is more of a suggestion/enhancement than a bug: I'm not sure whether this issue should be responsibility of the library. I might also be applying the LocalForm wrong — any hints or suggestions would be very welcome!

---

The Problem

Form debouncing works perfectly by itself. However, when the form is removed from the page / unmounted, any changes that are still delayed by the debouncing are lost.

Steps to Reproduce

In the example, make a change to the form and change the UI state before the debounce delay is reached. The onChange callback does not get called, and the change is lost.

Expected Behavior

It would (in my view) be fantastic if the debouncing could be flushed when either the form or the control is removed/unmounted from the app, so that any remaining changes are applied.

Actual Behavior

Pending changes are lost.

Reproducible Code Example

I've put together a very basic example at https://codepen.io/anon/pen/pPmjGZ . I sincerely hope it makes sense, and would be happy to make changes or answer questions.

---

I would be glad to help with resolving this issue if that were ok with you, though it might take some talking through the RRF internals for me to be able to help effectively. Again — it might well be that my approach is wrong, and I would be happy to learn in that case.

Thanks again, and the best regards,

-Felix

[davidkpiano]

This sounds like something that's a good idea - I'll get it done this weekend.

[FelixHenninger]

Hi @davidkpiano, thanks for the super-quick response! If there is anything I can do to help with this, do let me know, I'd be glad to assist.

I've noticed that debouncing is not covered in the docs, would you like me to draft a brief section? (I'll need until the end of the week to get around to this, but I'd be happy to give it a try. This would go in the Control component API docs, right?)