-
-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat]: watchFocus option #937
Conversation
Thanks for your contribution @S-Shingler 👍🏻, I’m on vacation so I will review and test this when I’m back. Thank you for your patience. |
No worries, enjoy your vacation! |
Hi @Mitch-At-Work, Thanks for your input. I think it's better to create a separate discussion if you're unsure about how the current focus behavior is operating. By all means, what you're mentioning could be a bug but it could also be by design and you might be misunderstanding the feature. I think it makes sense to not aim for just opting out of this feature if it's causing you trouble, but rather creating a discussion with a CodeSandbox along with clear steps to reproduce the behavior you think is problematic. This way, if it turns out to be a bug, we can fix the bug and improve the library. If not, you might better understand why it works the way it does. With that said, this feature is on the roadmap and I will review and test this PR as soon as possible so it's upcoming: |
ff1141c
to
3840f4e
Compare
3840f4e
to
6d65558
Compare
Hi @S-Shingler, I've made some modifications in order to align the In you local environment, you can try any of the three playgrounds and test the new feature out:
All environments live in this folder: Thanks in advance. |
Hi @davidjerleke, Everything is looking good. Cheers, |
c7b3823
to
87e1027
Compare
Co-authored-by: Samuel Shingler <samuel.shingler@tvnz.co.nz> Co-authored-by: David Jerleke <david.jerleke@gmail.com>
87e1027
to
e844f3e
Compare
@S-Shingler, @Mitch-At-Work, this feature has been included in the v8.2.0 release. Thanks a lot for your contribution 💫! |
That's awesome, thank you! @davidjerleke |
Hi David,
Firstly, thank you for an awesome package!
I went more in depth regarding my issue in this discussion:
Essentially I need a way to override the default slide focus behaviour for some accessibility work I've been doing.
A
watchFocus
option feels natural to me but curious to hear your thoughts.Cheers,
Sam
Closes: