Fix errors when embedding on Pastel (usepastel.com) #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to fix errors that occur on sites that override the `window` global with a Proxy'd version of their own. Specifically, this happens on sites embedded on https://usepastel.com See the files at https://github.com/romellem/temp-site/tree/master/embla-carousel for more information on this. If it is still up and running, the above repo is embedded at https://usepastel.com/link/2w7yy/ Otherwise, simply clone that repo, spin up a GitHub Pages site, create a free account on Pastel, and create a new "canvas" from your new site. Navigate to the `works.html` and `fails.html` pages to view the errors.
|
Hello Matt @romellem, Best |
|
@romellem from what I can see this has no effect on functionality or performance so I just merged it. I'll let you know when I've released this. Welcome to the contributors club 🙂. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix errors that occur on sites that override the
windowglobal with a Proxy'd version of their own. I am not sure exactly why this is causing errors, but on its face its not surprising thatsomeFunction.bind(window)whenwindowis actually a customProxymight not work correctly.Specifically, this happens on sites embedded on https://usepastel.com
For a test of this, navigate to
Navigate to the works.html and fails.html pages to view the errors. The works.html page uses a build from the same changes made in this PR.
If the above pastel link is down, run through the following to recreate: