-
-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat]: For Vue docs, use a more common SFC format #701
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mujahidfa,
Thanks a lot for your contribution, great initiative 👍. While at it, would you mind going through the code blocks in the API section and see if we can find more places where we could use the more succinct syntax? For example (.mdx
files are located here):
- https://www.embla-carousel.com/api/options/
- https://www.embla-carousel.com/api/methods/
- https://www.embla-carousel.com/api/events/
- https://www.embla-carousel.com/api/plugins/
Thanks a lot for your time!
Best,
David
packages/embla-carousel-docs/src/content/pages/get-started/vue.mdx
Outdated
Show resolved
Hide resolved
packages/embla-carousel-docs/src/content/pages/get-started/vue.mdx
Outdated
Show resolved
Hide resolved
Implemented in aea826e! |
@mujahidfa thanks for the additions 🙂! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work ⭐️! I will merge this as soon as possible.
Thanks @mujahidfa for this. Really nice improvement ⭐. I decided to scrap the Best, |
Feature description
To use a format for Vue Single File Components (SFCs) that is more succint and commonly used by the Vue community.
As per what is shown in the Introduction page of the Vue docs:
<script setup>
is more commonly used, and<script setup>
-><template>
-><style scoped>
order is more commonHere's the current example found in the docs:
And here's the proposed change in format - less verbose, more commonly used: