Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relocating CONTRIBUTING.md to root directory #681

Merged
merged 1 commit into from
Jan 6, 2024
Merged

Relocating CONTRIBUTING.md to root directory #681

merged 1 commit into from
Jan 6, 2024

Conversation

zaaakher
Copy link
Contributor

@zaaakher zaaakher commented Jan 6, 2024

Moved CONTRIBUTING.md to the root directory as suggested in this comment

@zaaakher zaaakher mentioned this pull request Jan 6, 2024
Merged
@davidjerleke davidjerleke added the documentation Improvements or additions to documentation label Jan 6, 2024
@davidjerleke
Copy link
Owner

Thanks again @zaaakher ⭐!

@zaaakher
Copy link
Contributor Author

zaaakher commented Jan 6, 2024

@davidjerleke You're welcome brother 👍

@davidjerleke davidjerleke merged commit 7763103 into davidjerleke:master Jan 6, 2024
@davidjerleke davidjerleke added the resolved This issue is resolved label Jan 6, 2024
@zaaakher
Copy link
Contributor Author

zaaakher commented Jan 6, 2024

image

I thought these tabs were based on the .md files in the root directory but it turns out to be pre-determined for the following files only:

  • README.md
  • CODE_OF_CONDUCT.md
  • LICENSE
  • SECURITY.md

It's not a problem anyway 😁

didnt-know

@davidjerleke
Copy link
Owner

davidjerleke commented Jan 6, 2024 •
edited
Loading

image

I thought these tabs were based on the .md files in the root directory but it turns out to be pre-determined for the following files only:

  • README.md
  • CODE_OF_CONDUCT.md
  • LICENSE
  • SECURITY.md

It's not a problem anyway 😁

didnt-know

@zaaakher no problem at all! It seems to be convention to have the CONTRIBUTING.md in the project root anyway so thanks 🙂.

@zaaakher zaaakher deleted the zaaakher/patch-1 branch January 6, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation resolved This issue is resolved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zaaakher @davidjerleke