-
-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat]: Continuously running carousel (ticker, marquee, ..) #634
Conversation
davidjerleke
commented
Nov 16, 2023
- Closes: [Feat]: Continuously running carousel (ticker, marquee, ..) #114.
b117710
to
d896413
Compare
9aaaef9
to
616d365
Compare
5a873d3
to
44cb93f
Compare
4a65c03
to
490fa5e
Compare
45ff5c7
to
e6953b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should change the element that has a focus listener from root
to container
, in order to prevent previous/next buttons and other focusable things outside the container (but inside the root) from stopping the carousel.
packages/embla-carousel-auto-scroll/src/components/AutoScroll.ts
Outdated
Show resolved
Hide resolved
packages/embla-carousel-auto-scroll/src/components/AutoScroll.ts
Outdated
Show resolved
Hide resolved
4dcbcf9
to
56b9877
Compare
56b9877
to
0cf986a
Compare
any docs on how to use it ? thx |
@decapination-labs docs here, and React CodeSandbox here, but: Warning You should read this first 😢. |
yes i am waiting for the updates !! something to point we dont have onMouseHover? and onTouchIn ? |
@decapination-labs could you elaborate? I don't understand what you mean? |
if i hover my mouse on the carousel item ( without clicking ) , the autoplay stops !! the same for mobile on touch |
@decapination-labs have you checked the following options? You should be able to configure it. |
oh sorry i think i messed up with the options delay and duration before u release the upates to have a close ux haha and looks like the stoponmouseenter works fine . plz let me know when u release because need that feature even though i have to tweak it a bit because i want continious smooth sliding and dragfree without reInit maybe or something other api calls which affecting the (continue smooth scroll) after i release the mouse |
@decapination-labs please take some time to read the API to better understand how it works here. |
i am facing an issue , i am creating 2 parallel carousel each sliding in different direction ! (nextjs + shadcnui) this looks ok for sliding rtl but if i change that direction to ltr then the carousel starts to behave weird !! can u help plz |
@decapination-labs you're using the |
yes in the meantime and before u publish , i am checking the autoplay which also have the direction option .. that sandbox from the playgroun anyway , not sure why if i change the direction it starts to behave weird . but if u cant answer that its fine i will wait the publish to use another plugin |
@decapination-labs have you read the docs about the Note Note: When using So whenever changing the |
ohhhh i missed that note .. thank you again and i am waiting the autoscroll publish !! |
is it published or not yet ? |
@decapination-labs the person who had the name on npm unpublished their package yesterday so that frees up the name. BUT, for reasons I don’t know, npm blocks any new releases for that name for 24h. It hasn’t been 24h yet. |
ok cool . will be waiting the update . thanks |