Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]: Continuously running carousel (ticker, marquee, ..) #634

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

davidjerleke
Copy link
Owner

@davidjerleke davidjerleke added the feature request New feature or request label Nov 16, 2023
@davidjerleke davidjerleke self-assigned this Nov 23, 2023
@davidjerleke davidjerleke added the plugin Issue is related to plugins label Nov 27, 2023
@davidjerleke davidjerleke force-pushed the feature/#114 branch 2 times, most recently from b117710 to d896413 Compare December 4, 2023 19:42
@davidjerleke davidjerleke force-pushed the feature/#114 branch 6 times, most recently from 9aaaef9 to 616d365 Compare December 26, 2023 20:34
@davidjerleke davidjerleke force-pushed the feature/#114 branch 2 times, most recently from 5a873d3 to 44cb93f Compare January 8, 2024 19:45
Repository owner deleted a comment from yunusga Jan 14, 2024
Copy link
Owner Author

@davidjerleke davidjerleke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should change the element that has a focus listener from root to container, in order to prevent previous/next buttons and other focusable things outside the container (but inside the root) from stopping the carousel.

@davidjerleke davidjerleke force-pushed the feature/#114 branch 3 times, most recently from 4dcbcf9 to 56b9877 Compare January 21, 2024 21:53
@davidjerleke davidjerleke changed the title Continuously running carousel (ticker, marquee, ..) [Feat]: Continuously running carousel (ticker, marquee, ..) Jan 25, 2024
@davidjerleke davidjerleke merged commit 9f21caa into master Jan 26, 2024
1 check passed
@davidjerleke davidjerleke added the resolved This issue is resolved label Jan 26, 2024
@decapination-labs
Copy link

any docs on how to use it ? thx

@davidjerleke davidjerleke deleted the feature/#114 branch January 26, 2024 10:26
@davidjerleke
Copy link
Owner Author

davidjerleke commented Jan 26, 2024

@decapination-labs docs here, and React CodeSandbox here, but:

Warning

You should read this first 😢.

@decapination-labs
Copy link

yes i am waiting for the updates !! something to point we dont have onMouseHover? and onTouchIn ?

@davidjerleke
Copy link
Owner Author

something to point we dont have onMouseHover? and onTouchIn ?

@decapination-labs could you elaborate? I don't understand what you mean?

@decapination-labs
Copy link

if i hover my mouse on the carousel item ( without clicking ) , the autoplay stops !!

the same for mobile on touch

@davidjerleke
Copy link
Owner Author

davidjerleke commented Jan 26, 2024

@decapination-labs have you checked the following options?

You should be able to configure it.

@decapination-labs
Copy link

oh sorry i think i messed up with the options delay and duration before u release the upates to have a close ux haha and looks like the stoponmouseenter works fine . plz let me know when u release because need that feature even though i have to tweak it a bit because i want continious smooth sliding and dragfree without reInit maybe or something other api calls which affecting the (continue smooth scroll) after i release the mouse

@davidjerleke
Copy link
Owner Author

@decapination-labs please take some time to read the API to better understand how it works here.

@decapination-labs
Copy link

i am facing an issue , i am creating 2 parallel carousel each sliding in different direction ! (nextjs + shadcnui)

https://codesandbox.io/p/sandbox/embla-carousel-generator-react-forked-k5h2lm?file=%2Fsrc%2Fjs%2Findex.tsx%3A15%2C13

this looks ok for sliding rtl but if i change that direction to ltr then the carousel starts to behave weird !! can u help plz

@davidjerleke
Copy link
Owner Author

davidjerleke commented Jan 26, 2024

@decapination-labs you're using the Autoplay plugin and not AutoScroll? This PR is for the AutoScroll plugin only.

@decapination-labs
Copy link

yes in the meantime and before u publish , i am checking the autoplay which also have the direction option .. that sandbox from the playgroun anyway , not sure why if i change the direction it starts to behave weird .

but if u cant answer that its fine i will wait the publish to use another plugin

@davidjerleke
Copy link
Owner Author

davidjerleke commented Jan 26, 2024

@decapination-labs have you read the docs about the direction options? It says:

Note

Note: When using rtl, the content direction also has to be set to RTL, either by using the HTML dir attribute or the CSS direction property.

So whenever changing the direction option, you also need to change this.

@decapination-labs
Copy link

ohhhh i missed that note .. thank you again and i am waiting the autoscroll publish !!

@decapination-labs
Copy link

@decapination-labs docs here, and React CodeSandbox here, but:

Warning

You should read this first 😢.

is it published or not yet ?

@davidjerleke
Copy link
Owner Author

davidjerleke commented Jan 28, 2024

@decapination-labs the person who had the name on npm unpublished their package yesterday so that frees up the name. BUT, for reasons I don’t know, npm blocks any new releases for that name for 24h. It hasn’t been 24h yet.

@decapination-labs
Copy link

ok cool . will be waiting the update . thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request plugin Issue is related to plugins resolved This issue is resolved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat]: Continuously running carousel (ticker, marquee, ..)
2 participants