Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make reading element dimensions work regardless of transforms #633

Merged
merged 6 commits into from
Nov 28, 2023
Merged

Make reading element dimensions work regardless of transforms #633

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9ad8b9d
fix when container is scaled
javiergonzalezGenially Nov 16, 2023
a84e3d1
fix tests
javiergonzalezGenially Nov 16, 2023
91217c0
remove unneeded getBoundingClientRect from mocks
javiergonzalezGenially Nov 16, 2023
1a5c01c
improve mock function name
javiergonzalezGenially Nov 16, 2023
ab973c9
Add NodeRect component.
davidjerleke Nov 25, 2023
c0ab441
Update test fixtures to use offsets instead of rects.
davidjerleke Nov 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update test fixtures to use offsets instead of rects.
  • Loading branch information
@davidjerleke
davidjerleke committed Nov 26, 2023
commit c0ab441ffe66c9b09021fdfcc42ee1a2a1f51f4d
2 changes: 1 addition & 1 deletion packages/embla-carousel/src/__tests__/constructor.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ describe('➡️ EmblaCarousel', () => {
expect(() =>
EmblaCarousel(
mockTestElements({
slideRects: [],
slideOffsets: [],
endMargin: {
property: 'marginRight',
value: 0
Expand Down
Loading