-
-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add focus interaction to autoplay #615
Conversation
Hi @nwidynski, I think this is a good idea. Thank you for your efforts! I will test this when I get the chance and get back to you. Best, |
Hi @nwidynski, I just tested this and it's working well except one bug. To reproduce:
At the time of writing I don't know what's causing this so we'll have to investigate it a bit before we can merge this. Best, |
@nwidynski I found the culprit. I will share more information soon about how to proceed with this PR. Thank you for your patience. |
@nwidynski thank you for your contribution ⭐! |
@nwidynski I've released |
Feature request is related to
A clear and concise description of what the problem is.
The current implementation of stopOnInteraction does not stop if focus is received by a nested element.
Describe the solution you'd like
This PR adds event handlers to the autoplay plugin to stop the autoplay if a bubbled up focus event is received by the root element.