Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Examples url path corrected #530

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

Ronit-gurjar
Copy link
Contributor

Examples url path was wrong

  • Hey david. I have corrected the link for Examples url path. Before, when it was clicked, a 404 page was appearing. Now it lands on the Examples: Overview page.

  • I was looking for a package to help me in one of my project and I was recommended Embla Carousel package so i checked it out on npm's official page and found this issue there.

@davidjerleke
Copy link
Owner

Hi @Ronit-gurjar,

Thanks a lot for reporting this and your PR ⭐. Would you mind changing the links on all package README's? Because all of them have a link to the examples page. For example the docs README. Don't feel obligated to. I'll do it when possible if you don't have time.

Best,
David

@davidjerleke davidjerleke added the documentation Improvements or additions to documentation label Jul 11, 2023
@Ronit-gurjar
Copy link
Contributor Author

I would be glad to do it

@davidjerleke
Copy link
Owner

Thanks @Ronit-gurjar, go ahead and do it when possible 🙏.

@davidjerleke davidjerleke merged commit 9ede19d into davidjerleke:master Jul 12, 2023
@davidjerleke davidjerleke added the resolved This issue is resolved label Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation resolved This issue is resolved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants