Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add React ^16.8 and ^17 to peer deps. #392

Merged
merged 2 commits into from
Nov 8, 2022

Conversation

horseeyephil
Copy link
Contributor

PR:

Discussion: #391

Adds more versions of React so that projects that don't use 18 may install embla-carousel-react without errors of the missing peer dependency. This would usually require --force or --legacy-peer-deps to bypass.

Validation:

  • Forked repo and add commit: https://github.com/horseeyephil/embla-carousel/commits/master
  • Used gitpkg (https://gitpkg.vercel.app/) to point to the packages/embla-carousel-react subdirectory.
    Install as such: npm install 'https://gitpkg.now.sh/horseeyephil/embla-carousel/packages/embla-carousel-react?master'
  • Install into a new project using React 17 as a dependency in package.json. The usual peer dependency error is not apparent.
  • Validate: Change the dependency from React 17 to React 15 (outside of the new range). Observe errors (or warning if using Yarn):

Screen Shot 2022-11-05 at 8 37 46 PM

@davidjerleke davidjerleke linked an issue Nov 8, 2022 that may be closed by this pull request
1 task
@davidjerleke davidjerleke added the dependencies Pull requests that update a dependency file label Nov 8, 2022
@davidjerleke davidjerleke merged commit 3819936 into davidjerleke:master Nov 8, 2022
@davidjerleke
Copy link
Owner

davidjerleke commented Nov 8, 2022

Thank you very much @horseeyephil for this PR and taking time to test this. Welcome to the contributors club ⭐!

@davidjerleke davidjerleke added the resolved This issue is resolved label Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file resolved This issue is resolved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Won't install on React 17
2 participants