Add a hint for flexbox and autoheight compatability #294
Conversation
|
Attempts to address #292 |
|
@JoshuaCrewe thanks a bunch 👍🏻. I’ll change the setup so you only have to run I’ll merge this soon. Again, thanks! |
|
So I don't use When I have more time I am willing to give it more of a go! |
|
@JoshuaCrewe would you mind rebasing your changes on the master branch? I tried but it was rejected. I don’t think I have the permissions to do anything on your fork. |
|
Absolutely. It is Saturday today which means shabbat wins out. There will be a short delay until I am back at my computer (just FYI) 🙌 |
|
@JoshuaCrewe haha no rush! Take your time. I’m just happy you want to contribute 👍🏻. |
When following along with the Get Started guide, the example CSS doesn't allow autoheight to work properly. The flex container will set all the slides to be the same height making the autoheight script useless. Adding some direction to the docs to amend the example CSS will help avoid this issue.
|
If I did it right, then the latest from your |
|
@JoshuaCrewe the rebase was successful. Welcome to the contributors club 🙂. Feel free to contribute again, it's very much appreciated. Thank you 🎉! |
|
🎉 🎉 🎉 For the record, you did 90% of the work. I am very happy to have pushed the 10% 😊 |
When following along with the Get Started guide, the example CSS doesn't
allow autoheight to work properly. The flex container will set all the
slides to be the same height making the autoheight script useless.
Adding some direction to the docs to amend the example CSS will help
avoid this issue.
I couldn't get gatsby to build the site so this PR is blind I am afraid. Seeing
as the suggestion is a minor one, I didn't foresee this being a major issue.
Feel free to insist, it will be a bit of a gap before I can update the PR in that case.
Feedback, criticism and amend requests welcome.