[Feat]: Trigger event (autoplay:select) on autoplay index update #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidjerleke
added
feature request
davidjerleke
requested changes
Nov 7, 2024
There was a problem hiding this comment.
Nicely done 👍.
Just two minor comments. In addition to these, we should add the event to the docs.
Mitch-At-Work
commented
Nov 7, 2024
davidjerleke
changed the title
davidjerleke
approved these changes
Nov 7, 2024
davidjerleke
added
APPROVED 👍
|
Thanks for your contribution @Mitch-At-Work. Feel free to squash the commits into to a single commit with the message:
Then it’s ready for a merge. If not, I will do it when possible. Cheers 👍🏻! |
davidjerleke
changed the title
Mitch-At-Work
force-pushed
the
autoplay-triggered-event
branch
from
6852be1 to
71a5d47
Compare
|
@Mitch-At-Work great work and thanks for your contribution. This feature will be included in the next release 🥳. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emit autoplay:triggered event on autoplay index change as discussed in:
Event is emitted after index change; listeners can retrieve the latest selectedScrollSnap from emblaApi regardless of direction to be compatible with upcoming autoplay direction feature.