Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: "Smoothness" of Slide Transitions feels degraded between 8.1.5 and 8.1.6 #928

Closed
4 of 15 tasks
taylorfsteele opened this issue Jul 2, 2024 · 7 comments · Fixed by #933
Closed
4 of 15 tasks
Assignees
Labels
bug Something isn't working core This is related to the core package resolved This issue is resolved

Comments

@taylorfsteele
Copy link

Which variants of Embla Carousel are you using?

  • embla-carousel (Core)
  • embla-carousel-react
  • embla-carousel-vue
  • embla-carousel-svelte
  • embla-carousel-autoplay
  • embla-carousel-auto-scroll
  • embla-carousel-solid
  • embla-carousel-auto-height
  • embla-carousel-class-names
  • embla-carousel-fade
  • embla-carousel-docs (Documentation)
  • embla-carousel-docs (Generator)

Steps to reproduce

  1. Go to any example found via the docs in codesandbox. E.g., Vanilla + TypeScript: https://codesandbox.io/s/xkygsv
  2. Fork the sandbox, and pin embla-carousel in package.json to 8.1.5. Restart to recompile the sandbox: https://codesandbox.io/s/embla-carousel-default-vanilla-forked-vqr66k?file=/package.json
  3. Compare the slide transitions between the two. 8.1.5 is noticeably "smoother" (at least to my eye).

Expected Behavior

The performance and "feel" of the slide transitions should be that of 8.1.5.

Additional Context

I could be completely off-base here, but I can definitely notice a difference between the two versions. Maybe I have super eyes or it's a 1st world problem with high refresh monitors 😆

What browsers are you seeing the problem on?

Chrome

Version

8.1.6

CodeSandbox

https://codesandbox.io/s/xkygsv

Before submitting

  • I've made research efforts and searched the documentation
  • I've searched for existing issues
  • I agree to follow this project's Contributing Guidelines for bug reports
@taylorfsteele taylorfsteele added the bug Something isn't working label Jul 2, 2024
@davidjerleke
Copy link
Owner

davidjerleke commented Jul 2, 2024

@taylorfsteele thanks for noticing.

Your observation is correct! This will be fixed in 8.1.7 and I’m hoping to make it even a bit smoother than 8.1.5. So please use 8.1.5 and stay tuned because there are no new actual features in 8.1.6 anyway.

@davidjerleke davidjerleke added the upcoming A feature or bug fix is on its way for this issue label Jul 2, 2024
@taylorfsteele
Copy link
Author

taylorfsteele commented Jul 2, 2024

Appreciate the fast reply! Glad to know it wasn't just me, I thought I might have been going crazy.

Let me know if I can provide any assistance, I just pulled the repo down to attempt a fix: My first instinct was that somehow removing this lag offset callback accidentally broke something somewhere, but that didn't work for me.

Regardless, if I can provide some form of help or contribution, I'm happy to do so 🙂

@davidjerleke
Copy link
Owner

davidjerleke commented Jul 4, 2024

Regardless, if I can provide some form of help or contribution, I'm happy to do so 🙂

@taylorfsteele thanks for being helpful 👍! Would you mind testing the following sandbox and see if the smoothness is back?

@taylorfsteele
Copy link
Author

Regardless, if I can provide some form of help or contribution, I'm happy to do so 🙂

@taylorfsteele thanks for being helpful 👍! Would you mind testing the following sandbox and see if the smoothness is back?

This looks really good to me! 🙌

@davidjerleke
Copy link
Owner

@taylorfsteele thanks a lot fot testing the sandbox 🙂. I'll let you know when I've released the bug fix with v8.1.7.

davidjerleke added a commit that referenced this issue Jul 6, 2024
rakyi added a commit to owid/owid-grapher that referenced this issue Jul 12, 2024
Version 8.1.6 has issues with smoothness of transitions.
davidjerleke/embla-carousel#928
rakyi added a commit to owid/owid-grapher that referenced this issue Jul 12, 2024
Version 8.1.6 has issues with smoothness of transitions.
davidjerleke/embla-carousel#928
rakyi added a commit to owid/owid-grapher that referenced this issue Jul 15, 2024
Version 8.1.6 has issues with smoothness of transitions.
davidjerleke/embla-carousel#928
rakyi added a commit to owid/owid-grapher that referenced this issue Jul 17, 2024
Version 8.1.6 has issues with smoothness of transitions.
davidjerleke/embla-carousel#928
rakyi added a commit to owid/owid-grapher that referenced this issue Jul 17, 2024
Version 8.1.6 has issues with smoothness of transitions.
davidjerleke/embla-carousel#928
@davidjerleke davidjerleke added the core This is related to the core package label Jul 18, 2024
davidjerleke added a commit that referenced this issue Jul 19, 2024
davidjerleke added a commit that referenced this issue Jul 19, 2024
davidjerleke added a commit that referenced this issue Jul 19, 2024
[Bug]: Add interpolation to fixed time step to improve animation smoothness
@davidjerleke davidjerleke added resolved This issue is resolved and removed upcoming A feature or bug fix is on its way for this issue labels Jul 19, 2024
@davidjerleke
Copy link
Owner

@taylorfsteele, @rakyi, a bug fix for this has been included in the v8.1.7 release.

@rakyi
Copy link

rakyi commented Jul 19, 2024

Thanks a lot, David! Embla is great.

rakyi added a commit to owid/owid-grapher that referenced this issue Jul 23, 2024
Version 8.1.6 has issues with smoothness of transitions.
davidjerleke/embla-carousel#928
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core This is related to the core package resolved This issue is resolved
Projects
None yet
3 participants