-
-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: "Smoothness" of Slide Transitions feels degraded between 8.1.5 and 8.1.6 #928
Comments
@taylorfsteele thanks for noticing. Your observation is correct! This will be fixed in |
Appreciate the fast reply! Glad to know it wasn't just me, I thought I might have been going crazy. Let me know if I can provide any assistance, I just pulled the repo down to attempt a fix: My first instinct was that somehow removing this lag offset callback accidentally broke something somewhere, but that didn't work for me. Regardless, if I can provide some form of help or contribution, I'm happy to do so 🙂 |
@taylorfsteele thanks for being helpful 👍! Would you mind testing the following sandbox and see if the smoothness is back? |
This looks really good to me! 🙌 |
@taylorfsteele thanks a lot fot testing the sandbox 🙂. I'll let you know when I've released the bug fix with |
Version 8.1.6 has issues with smoothness of transitions. davidjerleke/embla-carousel#928
Version 8.1.6 has issues with smoothness of transitions. davidjerleke/embla-carousel#928
Version 8.1.6 has issues with smoothness of transitions. davidjerleke/embla-carousel#928
Version 8.1.6 has issues with smoothness of transitions. davidjerleke/embla-carousel#928
Version 8.1.6 has issues with smoothness of transitions. davidjerleke/embla-carousel#928
[Bug]: Add interpolation to fixed time step to improve animation smoothness
@taylorfsteele, @rakyi, a bug fix for this has been included in the v8.1.7 release. |
Thanks a lot, David! Embla is great. |
Version 8.1.6 has issues with smoothness of transitions. davidjerleke/embla-carousel#928
Which variants of Embla Carousel are you using?
Steps to reproduce
package.json
to8.1.5
. Restart to recompile the sandbox: https://codesandbox.io/s/embla-carousel-default-vanilla-forked-vqr66k?file=/package.jsonExpected Behavior
The performance and "feel" of the slide transitions should be that of 8.1.5.
Additional Context
I could be completely off-base here, but I can definitely notice a difference between the two versions. Maybe I have super eyes or it's a 1st world problem with high refresh monitors 😆
What browsers are you seeing the problem on?
Chrome
Version
8.1.6
CodeSandbox
https://codesandbox.io/s/xkygsv
Before submitting
The text was updated successfully, but these errors were encountered: