Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Fade plugin has wrong peer dependency version #884

Closed
4 of 15 tasks
davidjerleke opened this issue May 20, 2024 · 0 comments · Fixed by #885
Closed
4 of 15 tasks

[Bug]: Fade plugin has wrong peer dependency version #884

davidjerleke opened this issue May 20, 2024 · 0 comments · Fixed by #885
Assignees
@davidjerleke
Labels
bug Something isn't working dependencies Pull requests that update a dependency file plugin Issue is related to plugins resolved This issue is resolved

Comments

@davidjerleke
Copy link
Owner

davidjerleke commented May 20, 2024 •
edited
Loading

Which variants of Embla Carousel are you using?

  • embla-carousel (Core)
  • embla-carousel-react
  • embla-carousel-vue
  • embla-carousel-svelte
  • embla-carousel-autoplay
  • embla-carousel-auto-scroll
  • embla-carousel-solid
  • embla-carousel-auto-height
  • embla-carousel-class-names
  • embla-carousel-fade
  • embla-carousel-docs (Documentation)
  • embla-carousel-docs (Generator)

Steps to reproduce

The bug occurs when I try to install the Fade plugin with a package manager. This is caused byt the wrong peer dependency version for the core package embla-carousel.

Expected Behavior

I should get no errors when installing the Fade plugin with a package manager.

Before submitting

  • I've made research efforts and searched the documentation
  • I've searched for existing issues
  • I agree to follow this project's Contributing Guidelines for bug reports
@davidjerleke davidjerleke added the bug Something isn't working label May 20, 2024
@davidjerleke davidjerleke self-assigned this May 20, 2024
@davidjerleke davidjerleke added dependencies Pull requests that update a dependency file plugin Issue is related to plugins labels May 20, 2024
davidjerleke added a commit that referenced this issue May 20, 2024
@davidjerleke
Bug fix for #884.
287b8dc
@davidjerleke davidjerleke mentioned this issue May 20, 2024
Merged
davidjerleke added a commit that referenced this issue May 20, 2024
@davidjerleke
Bug fix for #884.
957be14
davidjerleke added a commit that referenced this issue May 20, 2024
@davidjerleke
Merge pull request #885 from davidjerleke/bug/#884
960999a 
[Bug]: Fade plugin has wrong peer dependency version
@davidjerleke davidjerleke added the resolved This issue is resolved label May 20, 2024
@davidjerleke davidjerleke mentioned this issue May 20, 2024
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidjerleke davidjerleke

Labels
bug Something isn't working dependencies Pull requests that update a dependency file plugin Issue is related to plugins resolved This issue is resolved
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Bug]: Fade plugin has wrong peer dependency version davidjerleke/embla-carousel
1 participant
@davidjerleke