Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Render when slides are wider than view size #815

Closed
4 of 14 tasks
ferka123 opened this issue Apr 4, 2024 · 5 comments · Fixed by #805
Closed
4 of 14 tasks

[Bug]: Render when slides are wider than view size #815

ferka123 opened this issue Apr 4, 2024 · 5 comments · Fixed by #805
Assignees
@davidjerleke
Labels
bug Something isn't working core This is related to the core package resolved This issue is resolved

Comments

@ferka123
Copy link

ferka123 commented Apr 4, 2024

Which variants of Embla Carousel are you using?

  • embla-carousel (Core)
  • embla-carousel-react
  • embla-carousel-vue
  • embla-carousel-svelte
  • embla-carousel-autoplay
  • embla-carousel-auto-scroll
  • embla-carousel-solid
  • embla-carousel-auto-height
  • embla-carousel-class-names
  • embla-carousel-docs (Documentation)
  • embla-carousel-docs (Generator)

Steps to reproduce

The bug occurs when the windows width is 325px or when i resize it to less than 325px
The error: TypeError: Cannot read properties of undefined (reading 'right')
I left a codesandbox below

Expected Behavior

I expect it to work properly on any window width

Additional Context

I use next.js 13 with styled components

What browsers are you seeing the problem on?

Chrome

Version

v. 8.0.0

CodeSandbox

https://codesandbox.io/p/devbox/funny-williams-y3cdy8

Before submitting

  • I've made research efforts and searched the documentation
  • I've searched for existing issues
  • I agree to follow this project's Contributing Guidelines for bug reports
@ferka123 ferka123 added the bug Something isn't working label Apr 4, 2024
@ferka123
Copy link
Author

ferka123 commented Apr 4, 2024

It doesn't occur if i remove slidesToScroll: "auto"

@davidjerleke
Copy link
Owner

Thanks @ferka123 for your bug report. I wonder if this is related to?

I'll look into it when possible.

@davidjerleke davidjerleke changed the title [Bug]: TypeError when the windows is less than 325 px width [Bug]: Render when slides are wider than view size Apr 6, 2024
@davidjerleke davidjerleke linked a pull request Apr 6, 2024 that will close this issue
[Bug]: Render when slides are wider than view size #805
Merged
@davidjerleke davidjerleke added the core This is related to the core package label Apr 6, 2024
@davidjerleke
Copy link
Owner

davidjerleke commented Apr 6, 2024 •
edited
Loading

@ferka123 I've checked your CodeSandbox out and can confirm that this will be solved in the following PR:

@ferka123
Copy link
Author

ferka123 commented Apr 6, 2024

@davidjerleke Thank you! This would be most helpful

@davidjerleke davidjerleke added the resolved This issue is resolved label Apr 9, 2024
davidjerleke pushed a commit that referenced this issue Apr 10, 2024
@tlo-johnson @davidjerleke
Bug fix for #815.
438e4b0
@davidjerleke
Copy link
Owner

@ferka123 this has been released in v8.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidjerleke davidjerleke

Labels
bug Something isn't working core This is related to the core package resolved This issue is resolved
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Bug]: Render when slides are wider than view size fuelled/embla-carousel
2 participants
@davidjerleke @ferka123