Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Synced tabs doesn't always restore scroll position when selected tab changes #713

Closed
4 of 13 tasks
davidjerleke opened this issue Jan 23, 2024 · 0 comments · Fixed by #714
Closed
4 of 13 tasks

[Bug]: Synced tabs doesn't always restore scroll position when selected tab changes #713

davidjerleke opened this issue Jan 23, 2024 · 0 comments · Fixed by #714
Assignees
@davidjerleke
Labels
bug Something isn't working documentation Improvements or additions to documentation resolved This issue is resolved

Comments

@davidjerleke
Copy link
Owner

davidjerleke commented Jan 23, 2024 •
edited
Loading

What browsers are you seeing the problem on?

All

Steps to reproduce

  1. Go to a page with synced tabs, for example plugins.
  2. Find tabs and click on a tab that belongs to a tab group: For example React that belongs to the tab group library:
tabs
  1. Scroll down to another tab group for library and click on a different tab this time, for example Vue.
  2. Repeat step 2-3 until the page jumps unexpectedly.

Expected Behavior

Clicking on a synced tab should restore scroll position at all times - Meaning no page jump.

Which variants of Embla Carousel are you using?

  • embla-carousel (Core)
  • embla-carousel-react
  • embla-carousel-vue
  • embla-carousel-svelte
  • embla-carousel-autoplay
  • embla-carousel-solid
  • embla-carousel-auto-height
  • embla-carousel-class-names
  • embla-carousel-docs (Documentation)
  • embla-carousel-docs (Generator)

Before submitting

  • I've made research efforts and searched the documentation
  • I've searched for existing issues
  • I agree to follow this project's Contributing Guidelines for bug reports
@davidjerleke davidjerleke added bug Something isn't working documentation Improvements or additions to documentation labels Jan 23, 2024
@davidjerleke davidjerleke self-assigned this Jan 23, 2024
davidjerleke added a commit that referenced this issue Jan 23, 2024
@davidjerleke
Bug fix for #713.
cd753c3
@davidjerleke davidjerleke mentioned this issue Jan 23, 2024
Merged
davidjerleke added a commit that referenced this issue Jan 23, 2024
@davidjerleke
Merge pull request #714 from davidjerleke/bug/#713
bfa61e2 
[Bug]: Synced tabs doesn't always restore scroll position when selected tab changes
@davidjerleke davidjerleke added the resolved This issue is resolved label Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidjerleke davidjerleke

Labels
bug Something isn't working documentation Improvements or additions to documentation resolved This issue is resolved
Projects
None yet
Milestone
No milestone
1 participant
@davidjerleke