Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Nodenext support script to Rollup build end hook #663

Closed
7 tasks done
davidjerleke opened this issue Dec 26, 2023 · 0 comments · Fixed by #664
Closed
7 tasks done

Move Nodenext support script to Rollup build end hook #663

davidjerleke opened this issue Dec 26, 2023 · 0 comments · Fixed by #664
Labels
feature request New feature or request resolved This issue is resolved

Comments

@davidjerleke
Copy link
Owner

Feature request is related to

  • embla-carousel (core package)
  • embla-carousel-react
  • embla-carousel-vue
  • embla-carousel-svelte
  • embla-carousel-autoplay
  • embla-carousel-auto-height
  • embla-carousel-class-names

Is your feature request related to an issue?

  • A clear and concise description of what the problem is.

Describe the solution you'd like

  • I want to move the add nodenext support script to the Rollup build end hook. This will prepare for the future where the Embla Carousel plugin and library wrapper build scripts can be extracted to a separate package.
@davidjerleke davidjerleke added the feature request New feature or request label Dec 26, 2023
davidjerleke added a commit that referenced this issue Dec 26, 2023
@davidjerleke
Implement #663.
76d0493
@davidjerleke davidjerleke mentioned this issue Dec 26, 2023
Merged
davidjerleke added a commit that referenced this issue Dec 26, 2023
@davidjerleke
Implement #663.
eb0776d
davidjerleke added a commit that referenced this issue Dec 26, 2023
@davidjerleke
Merge pull request #664 from davidjerleke/feature/#663
77d6ec4 
Move Nodenext support script to Rollup build end hook
@davidjerleke davidjerleke added the resolved This issue is resolved label Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request resolved This issue is resolved
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move Nodenext support script to Rollup build end hook davidjerleke/embla-carousel
1 participant
@davidjerleke