Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SlideRegistry shouldn't group slides when containScroll:'trimSnaps' option is set #629

Closed
1 task done
Tracked by #321
davidjerleke opened this issue Nov 10, 2023 Discussed in #625 · 0 comments · Fixed by #630
Closed
1 task done
Tracked by #321

SlideRegistry shouldn't group slides when containScroll:'trimSnaps' option is set #629

davidjerleke opened this issue Nov 10, 2023 Discussed in #625 · 0 comments · Fixed by #630
Labels
bug Something isn't working resolved This issue is resolved

Comments

@davidjerleke
Copy link
Owner

davidjerleke commented Nov 10, 2023 •
edited
Loading

👉 Credit goes to @sarussss. Discussed in #625.

Bug is related to

  • embla-carousel (core package)

Embla Carousel version

  • v8.0.0-rc14

Describe the bug

  • When containScroll: 'keepSnaps' is set, SlideRegistry groups slides.

CodeSandbox

Expected behavior

Originally posted by davidjerleke November 10, 2023
When containScroll: 'keepSnaps' is set, it groups slides in the registry but it shouldn't.
@davidjerleke davidjerleke added the bug Something isn't working label Nov 10, 2023
@davidjerleke davidjerleke changed the title Plugin Class Names, Auto Height error when use with demo embla carousel thumbs SlideRegistry shouldn't group slides when containScroll: 'trimSnaps' option is set Nov 10, 2023
@davidjerleke davidjerleke changed the title SlideRegistry shouldn't group slides when containScroll: 'trimSnaps' option is set SlideRegistry shouldn't group slides when containScroll: 'trimSnaps' option is set Nov 10, 2023
@davidjerleke davidjerleke changed the title SlideRegistry shouldn't group slides when containScroll: 'trimSnaps' option is set SlideRegistry shouldn't group slides when containScroll:'trimSnaps' option is set Nov 10, 2023
@davidjerleke davidjerleke mentioned this issue Nov 10, 2023
Closed
37 tasks
davidjerleke added a commit that referenced this issue Nov 11, 2023
@davidjerleke
Fix bug #629.
4d9b422
@davidjerleke davidjerleke mentioned this issue Nov 11, 2023
Merged
davidjerleke added a commit that referenced this issue Nov 11, 2023
@davidjerleke
Merge pull request #630 from davidjerleke/bug/#629
48452b9 
Bugfix #629.
@davidjerleke davidjerleke added the resolved This issue is resolved label Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working resolved This issue is resolved
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bugfix #629 davidjerleke/embla-carousel
1 participant
@davidjerleke