Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Library crash when using breakpoints #519

Closed
1 task done
Tracked by #321
hamidrezahanafi opened this issue Jul 7, 2023 · 4 comments · Fixed by #521
Closed
1 task done
Tracked by #321

Library crash when using breakpoints #519

hamidrezahanafi opened this issue Jul 7, 2023 · 4 comments · Fixed by #521
Labels
bug Something isn't working resolved This issue is resolved

Comments

@hamidrezahanafi
Copy link
Contributor

hamidrezahanafi commented Jul 7, 2023 •
edited by davidjerleke
Loading

Bug is related to

  • embla-carousel (core package)

Embla Carousel version

  • v8.0.0-rc07

Describe the bug

  • When using breakpoints, if there are not enough slides to cover the whole screen, the library crashes
    RangeError Maximum call stack size exceeded optionsAtMedia

CodeSandbox

https://codesandbox.io/s/embla-carousel-arrow-dots-react-forked-h4lgy6?file=/src/js/index.tsx

Steps to reproduce

You should see the error on codesandbox

Expected behavior

  • It should just show the carousel

Additional context
@hamidrezahanafi hamidrezahanafi added the bug Something isn't working label Jul 7, 2023
@hamidrezahanafi hamidrezahanafi changed the title Library crash when using breakpoints without @media Library crash when using breakpoints Jul 7, 2023
@davidjerleke davidjerleke mentioned this issue Jul 7, 2023
Closed
37 tasks
@davidjerleke
Copy link
Owner

Hi @hamidrezahanafi,

Thank you for your complete bug report. I can confirm that this is a bug. I will create a fix for this and let you know when I've done so.

Best,
David

@davidjerleke davidjerleke added the upcoming A feature or bug fix is on its way for this issue label Jul 7, 2023
@davidjerleke davidjerleke mentioned this issue Jul 8, 2023
Merged
davidjerleke added a commit that referenced this issue Jul 8, 2023
@davidjerleke
Merge pull request #521 from davidjerleke/bug/#519
444199e 
Bugfix #519
@davidjerleke
Copy link
Owner

To be released with v8.0.0-rc09.

@davidjerleke davidjerleke reopened this Jul 8, 2023
@davidjerleke davidjerleke added resolved This issue is resolved and removed upcoming A feature or bug fix is on its way for this issue labels Jul 8, 2023
@davidjerleke
Copy link
Owner

davidjerleke commented Jul 8, 2023 •
edited
Loading

@hamidrezahanafi I've released a bug fix with v8.0.0-rc09. Give it a try and let me know if it's working as intended now.

@hamidrezahanafi
Copy link
Contributor Author

hamidrezahanafi commented Jul 8, 2023 •
edited
Loading

Confirmed, it's fixed and working as expected with v8.0.0-rc09.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working resolved This issue is resolved
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bugfix #519 davidjerleke/embla-carousel
2 participants
@davidjerleke @hamidrezahanafi