Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carousel isn't reactivating after resizing from a breakpoint with active: false #486

Closed
1 task done
Tracked by #321
turtlecrab opened this issue May 29, 2023 · 4 comments · Fixed by #487
Closed
1 task done
Tracked by #321

Carousel isn't reactivating after resizing from a breakpoint with active: false #486

turtlecrab opened this issue May 29, 2023 · 4 comments · Fixed by #487
Labels
bug Something isn't working resolved This issue is resolved

Comments

@turtlecrab
Copy link

turtlecrab commented May 29, 2023

Bug is related to

  • embla-carousel (core package)

Embla Carousel version

  • v8.0.0-rc05

Describe the bug

  • Carousel isn't reactivating after resizing from a breakpoint with active: false in 8.0.0-rc05. Works fine in 7.1.0

CodeSandbox

Steps to reproduce

  1. In the sandbox make sure that the width of the built-in browser is <600, if it's not - resize and refresh it
  2. Check that the carousel is working as expected
  3. Resize built-in browser so the width is > 600, check that the carousel stopped working
  4. Resize it back
  5. Observe that the carousel isn't working
  6. (optional) Change the version from 8.0.0-rc05 to 7.1.0 and repeat all the steps, observe that it's working as expected

Expected behavior

  • Should reactivate after resize
@turtlecrab turtlecrab added the bug Something isn't working label May 29, 2023
@davidjerleke
Copy link
Owner

davidjerleke commented May 30, 2023

Hi @turtlecrab,

Thank you for this crystal clear bug report. I can confirm that this is a bug. I will ship a fix for this in v8.0.0-rc06 as soon as possible. Stay tuned.

Best,
David

@davidjerleke
Copy link
Owner

@turtlecrab try this sandbox and see if that solves the problem. Let me know how it goes.

Best,
David

This was referenced May 30, 2023
@davidjerleke davidjerleke linked a pull request May 30, 2023 that will close this issue
@turtlecrab
Copy link
Author

@davidjerleke works fine on my side. Thank you for blazing fast fix!

@davidjerleke davidjerleke added the upcoming A feature or bug fix is on its way for this issue label May 31, 2023
davidjerleke added a commit that referenced this issue May 31, 2023
@davidjerleke davidjerleke added resolved This issue is resolved and removed upcoming A feature or bug fix is on its way for this issue labels May 31, 2023
@davidjerleke
Copy link
Owner

Released with v8.0.0-rc06. Thanks for this clear and well written bug report @turtlecrab!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working resolved This issue is resolved
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants