Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dragging not working well in Firefox for desktop #424

Closed
1 task done
scheinercc opened this issue Jan 23, 2023 · 3 comments · Fixed by #426
Closed
1 task done

Dragging not working well in Firefox for desktop #424

scheinercc opened this issue Jan 23, 2023 · 3 comments · Fixed by #426
Labels
bug Something isn't working resolved This issue is resolved

Comments

@scheinercc
Copy link

scheinercc commented Jan 23, 2023

Bug is related to

  • embla-carousel (core package)

Embla Carousel version

  • v7.0.8

Describe the bug

Tested with Firefox 108/109, macOS 12, M1

Trying to drag the image in the static default example to the left in order to move the carousel, results in a "drag&drop" of the whole image* rather than a drag of the carousel
*(smaller half-transparent version of the image follows the cursor)

I created a ticket in bugzilla, but opened this here as well, as this is working in other, similar components/examples like

Hence I am not sure if it is the browser or the component - or a combination.

CodeSandbox

https://codesandbox.io/s/work1o

Steps to reproduce

  1. open https://www.embla-carousel.com/examples/static/#default in Firefox
  2. mouse down in the image
  3. move to the left

Expected behavior

Smooth dragging of the carousel

Additional context

See bugzilla ticket for screencast: https://bugzilla.mozilla.org/show_bug.cgi?id=1811771

@scheinercc scheinercc added the bug Something isn't working label Jan 23, 2023
@davidjerleke
Copy link
Owner

davidjerleke commented Jan 23, 2023

Hi @scheinercc,

Thanks for reporting this 👍🏻. I suspect that this is related to the new passive event implementation:

Have you tried other browsers? Do you run into the same problem there?

Maybe I need to prevent the dragstart event default when the user is dragging the carousel.

I’ll let you know when I’ve investigated possible solutions. Meanwhile, If you find anything that could be useful, please share.

Cheers,
David

@davidjerleke davidjerleke changed the title Not working well in Firefox for desktop Dragging not working well in Firefox for desktop Jan 23, 2023
davidjerleke added a commit that referenced this issue Jan 23, 2023
@davidjerleke
Copy link
Owner

@scheinercc seems like Firefox is the only browser triggering the dragstart event on images 😕. A bug fix is on its way:

davidjerleke added a commit that referenced this issue Jan 23, 2023
Dragging not working well in Firefox for desktop
@davidjerleke davidjerleke added the resolved This issue is resolved label Jan 23, 2023
davidjerleke added a commit that referenced this issue Jan 23, 2023
@davidjerleke
Copy link
Owner

A bug fix has been released with v7.0.9. Thanks for creating this issue 👍🏻.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working resolved This issue is resolved
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants