Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle click prevention on drag automatically #422

Closed
1 task done
davidjerleke opened this issue Jan 21, 2023 · 2 comments · Fixed by #423
Closed
1 task done

Handle click prevention on drag automatically #422

davidjerleke opened this issue Jan 21, 2023 · 2 comments · Fixed by #423
Labels
feature request New feature or request resolved This issue is resolved

Comments

@davidjerleke
Copy link
Owner

davidjerleke commented Jan 21, 2023 •
edited
Loading

Feature request is related to

  • embla-carousel (core package)

Is your feature request related to an issue?

  • At the time of writing, the opt-in clickAllowed() method only return returns true when the user's pointer has not dragged the carousel.

Describe the solution you'd like

  • Embla should handle this automatically. It will make it convenient for devs to attach click listeners to slides without worrying about click events getting fired when users only drag the carousel.
@davidjerleke davidjerleke added the feature request New feature or request label Jan 21, 2023
davidjerleke added a commit that referenced this issue Jan 21, 2023
@davidjerleke
Implement #422
974a4e4
@davidjerleke davidjerleke mentioned this issue Jan 21, 2023
Merged
@davidjerleke davidjerleke linked a pull request Jan 21, 2023 that will close this issue
Handle click prevention on drag automatically #423
Merged
davidjerleke added a commit that referenced this issue Jan 21, 2023
@davidjerleke
Merge pull request #423 from davidjerleke/feature/#422
b8c4a23 
Handle click prevention on drag automatically
@davidjerleke davidjerleke added the resolved This issue is resolved label Jan 21, 2023
davidjerleke added a commit that referenced this issue Jan 21, 2023
@davidjerleke
Deploy docs with #422
d28d218
@richgcook
Copy link

Was clickAllowed removed?

@davidjerleke
Copy link
Owner Author

davidjerleke commented Nov 9, 2023 •
edited
Loading

@richgcook yes. It’s handled automatically now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request resolved This issue is resolved
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle click prevention on drag automatically davidjerleke/embla-carousel
2 participants
@richgcook @davidjerleke